Skip to content

fix(cloud_sql): remove deletion_protection from default #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

fix(cloud_sql): remove deletion_protection from default #848

merged 2 commits into from
Apr 28, 2025

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Apr 24, 2025 •
edited
Loading

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s): existing

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@apeabody apeabody marked this pull request as ready for review April 28, 2025 16:47
@apeabody apeabody requested review from a team as code owners April 28, 2025 16:47
@apeabody
Copy link
Contributor Author

Hi @glasnt - This doesn't cover cloud_sql resources not called default, but is probably a good place to start.

glasnt
glasnt approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This batch change fails testing due to changing tests itself. We can address any outlying updates after this PR is merged.

@glasnt glasnt merged commit 215059e into main Apr 28, 2025
9 of 10 checks passed
@apeabody apeabody deleted the ap/cloud_sql branch April 28, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glasnt glasnt glasnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeabody @glasnt